Revert "Support WASB scheme in ADLSFileIO" #11812
Merged
+16
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0963485.
Fokko
approved these changes
Dec 18, 2024
bryanck
approved these changes
Dec 18, 2024
amogh-jahagirdar
approved these changes
Dec 18, 2024
Contributor
|
Thanks for the reviews @Fokko and @amogh-jahagirdar , and the PR @mrcnc . |
mrcnc
added a commit
to mrcnc/iceberg
that referenced
this pull request
Dec 18, 2024
This reverts commit 0963485.
amogh-jahagirdar
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change introduced in 1.7.1 when using ADLSFileIO SAS tokens so this reverts #11504
For more info see this mailing list thread
https://lists.apache.org/thread/xc0ddyjkwdl8rhp072fcydl4rondogx6